-
-
Notifications
You must be signed in to change notification settings - Fork 0
Fix blank space #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix blank space #43
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot wasn't able to review any files in this pull request.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
📝 WalkthroughWalkthroughAdjusted generated code formatting in PublicApiSourceGenerator to insert a space after the lambda arrow in an internal property getter. No changes to public/external APIs. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Suggested labels
Suggested reviewers
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal). Please share your feedback with us on this Discord post. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
Flow.Launcher.Localization.SourceGenerators/Localize/PublicApiSourceGenerator.cs (1)
89-89
: Close the XML doc tag.Use a self-closing to avoid XML doc warnings.
- sourceBuilder.AppendLine($"{tabString}/// Get <see cref=\"Flow.Launcher.Plugin.IPublicAPI\"> instance"); + sourceBuilder.AppendLine($"{tabString}/// Get <see cref=\"Flow.Launcher.Plugin.IPublicAPI\"/> instance");
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
Flow.Launcher.Localization.SourceGenerators/Localize/PublicApiSourceGenerator.cs
(1 hunks)
🧰 Additional context used
🧬 Code graph analysis (1)
Flow.Launcher.Localization.SourceGenerators/Localize/PublicApiSourceGenerator.cs (1)
Flow.Launcher.Localization.Shared/Constants.cs (1)
Constants
(5-35)
🔇 Additional comments (1)
Flow.Launcher.Localization.SourceGenerators/Localize/PublicApiSourceGenerator.cs (1)
91-92
: Whitespace after => in generated property LGTM.Change is purely formatting and safe. Improves readability of the generated code without affecting behavior.
Add space for code quality
In this place, we should add one space for code quality